Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AAE-3115] Make selectionMode optioanl in ContentNodeSelectorComponentData #5921

Merged
merged 1 commit into from
Jul 28, 2020
Merged

[AAE-3115] Make selectionMode optioanl in ContentNodeSelectorComponentData #5921

merged 1 commit into from
Jul 28, 2020

Conversation

sivakumar414ram
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@sivakumar414ram sivakumar414ram mentioned this pull request Jul 28, 2020
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2020 •
edited
Loading

Codecov Report

Merging #5921 into develop will increase coverage by 2.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5921      +/-   ##
===========================================
+ Coverage    76.07%   78.35%   +2.28%     
===========================================
  Files          843      334     -509     
  Lines        18718     8900    -9818     
  Branches      3680     1772    -1908     
===========================================
- Hits         14239     6974    -7265     
+ Misses        3360     1375    -1985     
+ Partials      1119      551     -568
Impacted Files Coverage Δ
...ntent-node-selector/content-node-dialog.service.ts 77.19% <ø> (ø)
lib/core/form/models/widget-visibility.model.ts
...core/datatable/components/data-row-action.event.ts
lib/core/services/jwt-helper.service.ts
lib/core/directives/upload.directive.ts
...re/viewer/components/pdf-viewer-thumb.component.ts
lib/core/mock/apps-service.mock.ts
lib/core/services/apps-process.service.ts
lib/core/models/pagination.model.ts
...components/raphael/raphael-flow-arrow.component.ts
... and 501 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a3fda...d437237. Read the comment docs.

@eromano eromano merged commit efc6432 into develop Jul 28, 2020
@eromano eromano deleted the dev-siva-make-selectMode-optional branch July 28, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eromano eromano eromano approved these changes

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sivakumar414ram @codecov-commenter @eromano